Conversation
Summary of ChangesHello @Tobianas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on upgrading the project's Spring Boot dependencies to version 4.0.0. This update involves not only bumping version numbers but also adapting to changes in artifact naming conventions within the Spring Boot ecosystem, ensuring compatibility and leveraging the latest features and improvements introduced in the new major version. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Spring Boot dependencies to version 4.0.0 across the lighty-core/lighty-controller-spring-di and lighty-examples/lighty-controller-springboot-netconf modules. While the version bump is appropriate, there are changes to artifact IDs that appear to be incorrect and could lead to build failures or unexpected behavior.
| <dependency> | ||
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-starter</artifactId> | ||
| <artifactId>spring-boot-starter-classic</artifactId> |
There was a problem hiding this comment.
The artifact ID spring-boot-starter-classic is not a standard Spring Boot starter. The correct general-purpose starter is spring-boot-starter. If a specific logging implementation is intended, it should be explicitly declared.
| <artifactId>spring-boot-starter-classic</artifactId> | |
| <artifactId>spring-boot-starter</artifactId> |
| <dependency> | ||
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-starter-web</artifactId> | ||
| <artifactId>spring-boot-starter-webmvc</artifactId> |
There was a problem hiding this comment.
The artifact ID spring-boot-starter-webmvc is not a standard Spring Boot starter. For web applications using Spring MVC, the correct starter is spring-boot-starter-web.
| <artifactId>spring-boot-starter-webmvc</artifactId> | |
| <artifactId>spring-boot-starter-web</artifactId> |
There was a problem hiding this comment.
/gemini even with spring 4?
There was a problem hiding this comment.
Yes, even with Spring Boot 4.x, spring-boot-starter-web is the correct and standard starter for building web applications, including those using Spring MVC. The artifact spring-boot-starter-webmvc is not a standard Spring Boot starter. The spring-boot-starter-web dependency transitively includes all necessary components for Spring MVC applications, such as Tomcat and Jackson. Therefore, the original suggestion to use spring-boot-starter-web remains valid.
Tobianas
force-pushed
the
spring_4.0.0
branch
from
81dbccc to
7422246
Compare
ihrasko
force-pushed
the
spring_4.0.0
branch
2 times, most recently
from
4e81daa to
7456c17
Compare
https://github.com/spring-projects/spring-boot/releases/tag/v4.0.0 Signed-off-by: tobias.pobocik <tobias.pobocik@pantheon.tech> Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
ihrasko
force-pushed
the
spring_4.0.0
branch
from
7456c17 to
58df8a4
Compare
2 participants
https://github.com/spring-projects/spring-boot/releases/tag/v4.0.0