Add missing explicit include of <string> #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's unconditionally used in the type definition of rlbox_sandbox::func_ptr_map
shravanrn
approved these changes
Dec 15, 2025
Contributor
Author
|
FYI, this got caught by linking with libcxx and setting |
lando-prod-mozilla bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
Dec 16, 2025
Backport of PLSysSec/rlbox#59 Differential Revision: https://phabricator.services.mozilla.com/D276422
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Dec 17, 2025
Backport of PLSysSec/rlbox#59 Differential Revision: https://phabricator.services.mozilla.com/D276422
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Dec 20, 2025
Backport of PLSysSec/rlbox#59 Differential Revision: https://phabricator.services.mozilla.com/D276422 UltraBlame original commit: 5ffd259042c82ccf3cb899ada8d266dffced59ba
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Dec 20, 2025
Backport of PLSysSec/rlbox#59 Differential Revision: https://phabricator.services.mozilla.com/D276422 UltraBlame original commit: 5ffd259042c82ccf3cb899ada8d266dffced59ba
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Dec 20, 2025
Backport of PLSysSec/rlbox#59 Differential Revision: https://phabricator.services.mozilla.com/D276422 UltraBlame original commit: 5ffd259042c82ccf3cb899ada8d266dffced59ba
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's unconditionally used in the type definition of rlbox_sandbox::func_ptr_map