Open
Conversation
- Added new entries to .gitignore for local files and test scripts. - Updated IGRF coefficients in geopack_08.f to reflect the latest values as of December 24, 2024, and adjusted the date range for model acceptance to 2030.
The storm-time branch (k_ext=10, Tsyganenko 2001 storm) was silently calling T01_01 (quiet-time model) instead of T01_S (storm-time model). Both share the same subroutine interface so the bug compiled without error but produced incorrect results: T01_01 expects G1 and G2 in PARMOD(5:6), while T01_S expects G2 and G3, which is what the PARMOD assignments at lines 220-221 correctly provide. Also fix comment at line 213: "G1,G2" → "G2,G3". Historical k_ext=10 results will differ after this fix.
…olve Make error Fixed a Fortran fixed-form formatting issue in the IGRF coefficient DATA statement: replaced `-.04D0` with `-0.04D0`, split an overlong continuation line, and corrected the indentation of the `DATA G25` statement (5→6 spaces) so that the file compiles without errors.
…180 conversion T01_S computed ps = tilt * rad, where rad came from the uninitialized /rconst/ common block (only populated by SUBROUTINE INITIZE). When T01_S was called before INITIZE ran, rad = 0, giving ps = 0 (zero tilt) regardless of actual conditions. Replace with the self-contained formula ps = tilt * 4.D0*ATAN(1.D0)/180.d0, consistent with T89, T96, T01, and TS04. Remove the now-unused REAL*8 pi,rad and common /rconst/rad,pi declarations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.gitignoreforgeopack_08.fk_ext=10to correctly callT01_Sinstead ofT01_01geopack_08.fto resolve Make error/rconst/COMMON block dependency fromT01_Sand use self-containedpi/180conversionTest plan
make OS=osx64 ENV=gfortran64 allk_ext=10dispatches toT01_ScorrectlyT01_Sproduces correct results without/rconst/dependency