Check reference_id in description matches vector#83
Merged
saurabh1002 merged 5 commits intoPRBonn:mainfrom Nov 25, 2025
Merged
Conversation
saurabh1002
requested changes
Nov 24, 2025
saurabh1002
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
MatchAndAddToDatabase()is called with a frame that produces 0 HBST matchables (e.g., only 1-2 ORB keypoints detected, none passing the self-similarity check),matchAndAdd()returns early without updatingdescriptor_matches_. Subsequently, whenGetTopKClosures()iterates through reference frames and callsValidateClosure(), it throwsstd::out_of_rangebecause that reference_id isn't present in the map.Here I check if the reference id is actually present in descriptor_matches_. This seems to only happen in the latest version (the previous version extracted a lot more ORB keypoints).
I am using the algorithm with single scans of a Ouster OS1-128.