Conversation
for more information, see https://pre-commit.ci
eitsupi
commented
Oct 9, 2024
Comment on lines
+522
to
+524
| # TODO: remove this version pinning | ||
| # The latest 0.16 supports workspace inheritance, so the check will fail | ||
| version: "0.15" |
Member
Author
There was a problem hiding this comment.
I think this is needed to pass the test for now.
Will be fixed by #4941
Member
Author
|
If we do not merge this, all CI for any PRs will fail, so I will merge for now. |
Member
|
Thanks a lot! I guess we need to add python onto the images. (would be great if we could pin the images + have dependabot upgrade them, but seems that dependabot doesn't do this...) |
Member
Author
Python is included in ubuntu-24.04. Do you think we need to install something like libpython-dev with apt? Details |
Member
|
Ah, interesting. Possibly. I guess we'll hear from others fairly soon on what's required... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #4941 (comment)
So far, CI in this repository does not seem to support Ubuntu 24.04.