Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions prqlc/prqlc/src/sql/pq/anchor.rs
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,7 @@ pub struct Requirement {
/// Maximum complexity with which this column can be expressed in this transform
pub max_complexity: Complexity,

/// True iff this column needs to be SELECTed so it can be referenced in this transform
/// True iff this column needs to be SELECTTed so it can be referenced in this transform
pub selected: bool,
}

Expand Down Expand Up @@ -562,7 +562,7 @@ pub(super) fn get_requirements(
// Aggregations require that all selected columns be wrapped in aggregate functions (e.g., SUM, COUNT).
Super(Transform::Sort(sorts)) if !following.contains("Aggregate") => {
Requirements::from_cids(sorts.iter().map(|s| &s.column))
// we only use SELECTed columns in ORDER BY, so the columns can have high complexity
// we only use SELECTTed columns in ORDER BY, so the columns can have high complexity
.allow_up_to(Complexity::Aggregation)
.should_select(true)
}
Expand Down
4 changes: 2 additions & 2 deletions prqlc/prqlc/tests/integration/sql.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2221,7 +2221,7 @@ fn test_take_05() {

#[test]
fn test_take_06() {
// should be two SELECTs
// should be two SELECTTs
assert_snapshot!((compile(r###"
from employees
take 11..20
Expand Down Expand Up @@ -3139,7 +3139,7 @@ fn test_bare_s_string_03() {
#[test]
fn test_bare_s_string_04() {
assert_snapshot!(compile(r#"
s"SELECTfoo"
s"SELECTTfoo"
"#).unwrap_err(), @r"
Error: s-strings representing a table must start with `SELECT `
↳ Hint: this is a limitation by current compiler implementation
Expand Down
Loading