Skip to content

ECS health checks #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
farski merged 3 commits into from
Dec 17, 2025
Merged

ECS health checks #861

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
311755b
Add Spots tasks ECS health checks
farski Dec 3, 2025
2dbee48
Add Feeder worker health check
farski Dec 3, 2025
ca4331a
Remove unused !Subs
farski Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions spire/templates/apps/dovetail-spots.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,12 @@ Resources:
- Name: SPOTS_HOST
Value: !Ref SpotsHostname
Essential: true
HealthCheck:
Command: [ "CMD-SHELL", !Sub "curl --fail http://localhost:${kWebApplicationPort}/up || exit 1" ]
Copy link
Member

@cavis cavis Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the || exit 1 redundant? The --fail is already returning non-0 if we've gotten to the ||.

Interval: 30
Retries: 3
StartPeriod: 15
Timeout: 5
Image: !Sub ${AWS::AccountId}.dkr.ecr.${AWS::Region}.amazonaws.com/${EcrImageTag}
LinuxParameters:
InitProcessEnabled: true
Expand Down Expand Up @@ -440,6 +446,12 @@ Resources:
- Name: SPOTS_HOST
Value: !Ref SpotsHostname
Essential: true
HealthCheck:
Command: [ "CMD-SHELL", "pgrep -f solid-queue-worker || exit 1" ]
Interval: 30
Retries: 3
StartPeriod: 15
Timeout: 5
Image: !Sub ${AWS::AccountId}.dkr.ecr.${AWS::Region}.amazonaws.com/${EcrImageTag}
LinuxParameters:
InitProcessEnabled: true
Expand Down
6 changes: 6 additions & 0 deletions spire/templates/apps/feeder.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1092,6 +1092,12 @@ Resources:
- Name: WORKER_COUNT
Value: !If [IsProduction, 8, 5]
Essential: true
HealthCheck:
Command: [ "CMD-SHELL", "pgrep -f shoryuken || exit 1" ]
Interval: 30
Retries: 3
StartPeriod: 15
Timeout: 5
Image: !Sub ${AWS::AccountId}.dkr.ecr.${AWS::Region}.amazonaws.com/${EcrImageTag}
LinuxParameters:
InitProcessEnabled: true
Expand Down