More changes required to eliminate pylint warnings#402
Merged
martinholmer merged 6 commits intomasterfrom Feb 18, 2026
Merged
Conversation
Collaborator
|
Thank you, @martinholmer. I believe it will be potentially useful, sometime in the future, to examine that module carefully, update it as needed, and implement it. It could enable us to make modest improvements to how we target data. Doing that might be far in the future, but it's worth retaining the module, as you have done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes are cosmetic rather than substantive.
While looking at
pylintwarnings genratred by thetmd/utils/is_tax_filer.pycode, I discovered that theis_tax_filerfunction is not called anywhere in the TMD repo code. So, I added at comment indicating that fact (rather than removing the module).