refactor(auth): resolve OAuth auth mode at config-load time#5
Open
HungKNguyen wants to merge 1 commit into
Open
refactor(auth): resolve OAuth auth mode at config-load time#5HungKNguyen wants to merge 1 commit into
HungKNguyen wants to merge 1 commit into
Conversation
…f sandbox-create time Move secret.value prefix detection (sk-ant-oat → CLAUDE_CODE_OAUTH_TOKEN) from applyAgentAuth into validateConfig so auth mode is decided once during config loading. Extract shared resolveSecretValue helper into core/env.ts, simplify applyAgentAuth to a straight passthrough of secret.envVar, and add adapter-level oauthEnvVar/oauthValuePrefix fields so the detection logic is adapter-driven rather than hardcoded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sk-ant-oat→CLAUDE_CODE_OAUTH_TOKEN) fromapplyAgentAuth(sandbox-create time) intovalidateConfig(config-load time), so auth mode is decided once and stored onsecret.envVarresolveSecretValuehelper frommicrosandbox.tsintocore/env.tsto eliminate duplicationoauthEnvVar/oauthValuePrefixfields toAgentAdapterinterface so prefix detection is adapter-driven (currently Claude-only) rather than hardcodedapplyAgentAuthto a straight passthrough ofsecret.envVar— no more re-sniffing the credential prefix at runtimecreateAdaptercall inexecute.ts