Add ready_for_review trigger to code review workflow#32
Merged
nickwinder merged 3 commits intomainfrom Mar 3, 2026
Merged
Conversation
There was a problem hiding this comment.
📋 PR Summary:
This PR adds the ready_for_review trigger type to handle draft PRs being promoted to ready status, replacing the review_requested trigger which was only working accidentally due to GitHub Copilot's auto-reviewer ruleset. The change ensures the workflow fires directly when a draft PR becomes ready, without depending on external tooling.
2 files reviewed
| File | Changes |
|---|---|
.github/workflows/code-review.yml |
Replace review_requested with ready_for_review trigger type |
action.yml |
Map ready_for_review to 'open' trigger type in case statement |
No issues found. Changes look good.
pweiskircher
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The workflow was missing the `ready_for_review` trigger, meaning it would not fire when a draft PR was converted to ready for review.
In practice this appeared to work — but only by accident. With GitHub Copilot's automatic reviewer ruleset enabled, Copilot auto-assigns itself as a reviewer when a PR becomes ready. That auto-assignment fires a `review_requested` event, which was in the trigger list, causing the workflow to run indirectly.
This created a hidden dependency on Copilot being installed and configured. Without it (or if the ruleset changes), the workflow would silently stop triggering for draft PRs being promoted to ready.
`review_requested` is also removed for the same reason — it was only serving as the accidental workaround. Re-triggering via `@mention` is already handled by the `issue_comment` trigger.
References:
Summary