[Document Engine] Add StatefulSet support with persistent storage#118
Open
lazyoldbear wants to merge 4 commits intomasterfrom
Open
[Document Engine] Add StatefulSet support with persistent storage#118lazyoldbear wants to merge 4 commits intomasterfrom
lazyoldbear wants to merge 4 commits intomasterfrom
Conversation
lazyoldbear
changed the title
This introduces a configurable workload type (`Deployment` or `StatefulSet`) allowing users to deploy Document Engine pods with stable identities and per-pod persistent volumes via volumeClaimTemplates. Default remains Deployment for backward compatibility. Key changes: - Extracted pod template into _pod-template.tpl for reuse by both workload types - Added `document-engine.isStatefulSet` helper to centralize condition logic - Refactored scheduling and certificate trust helpers to reduce duplication in migration job - Updated headless service to be created for StatefulSet (required by serviceName) - Updated HPA to dynamically target StatefulSet when workloadType changes - Added `workloadType`, `podManagementPolicy`, and `persistence` configuration values - Modified CI tests 02 (clustering) and 05 (envoy-sidecar) to test StatefulSet with persistent storage Backward compatible: Default `workloadType: Deployment` produces identical output to previous version. StatefulSet volumes are mounted at /data with configurable storageClass and size. Chart version bumped to 8.0.0 (major change due to architectural flexibility). Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
lazyoldbear
force-pushed
the
lazyoldbear/docengine-statefulset
branch
from
ea60fc5 to
1c67356
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This introduces configurable Deployment/StatefulSet workload type for Document Engine, enabling per-pod persistent volumes via
volumeClaimTemplates. Default remains Deployment for backward compatibility.Changes
_pod-template.tplshared by both workload typesdocument-engine.isStatefulSethelper to centralize condition logic (no more| defaultin templates)Test Coverage
02-cnpg-clustering-values.yamland05-envoy-sidecar-values.yamlto test StatefulSet modehelm lint🤖 Generated with Claude Code