[API Compatibility No.109、110 ] sink log10 and log1p into c++ -part by zade23 · Pull Request #76381 · PaddlePaddle/Paddle

zade23 · 2025-11-12T09:50:25Z

PR Category

User Experience

PR Types

New features

Description

下沉paddle.log10、paddle.log1p 到C++层。

兼容torch input参数
增加out参数支持

任务：#76301
PaConvert：PaddlePaddle/PaConvert#755

paddle-bot · 2025-11-12T09:50:31Z

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

CLAassistant · 2025-11-12T09:50:32Z

All committers have signed the CLA.

Copilot

Pull Request Overview

This PR migrates paddle.log10 and paddle.log1p functions from Python to C++ implementation to improve performance and maintainability. The changes add PyTorch-compatible input parameter aliasing and introduce out parameter support for in-place operations.

Key changes:

Removed Python implementations of log10 and log1p from python/paddle/tensor/math.py
Added comprehensive API documentation with signatures to python/paddle/_paddle_docs.py
Added API mapping configuration in paddle/phi/ops/yaml/python_api_info.yaml
Added compatibility test suites covering both dygraph and static modes with multiple parameter patterns

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
test/legacy_test/test_activation_op.py	Added comprehensive test classes `TestLog10APICompatibility` and `TestLog1pAPI_Compatibility` to verify parameter compatibility, tensor methods, and output parameter functionality
python/paddle/tensor/math.py	Removed Python implementations of `log10` and `log1p` functions (now implemented in C++) and updated imports
python/paddle/_paddle_docs.py	Added detailed documentation and signatures for `log10` and `log1p` functions including math formulas, parameters, return values, and usage examples
paddle/phi/ops/yaml/python_api_info.yaml	Registered `log10` and `log1p` operations with Python API mappings for both module-level and tensor method access

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-12T10:00:35Z

+
+    .. math::
+
+        Out = \log_{10}x


[nitpick] The LaTeX formatting in the math block has inconsistent underscore usage. The formula should use proper subscript formatting:

Out = \log_{10}x

should be:

Out = \log_{10}{x}

to properly group the base and the argument, or use parentheses for clarity:

Out = \log_{10}(x)

Suggested change

Out = \log_{10}x

Out = \log_{10}{x}

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

codecov-commenter · 2025-11-12T21:11:23Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop@e9431ab). Learn more about missing BASE report.

Additional details and impacted files

@@             Coverage Diff             @@
##             develop    #76381   +/-   ##
===========================================
  Coverage           ?   100.00%           
===========================================
  Files              ?         1           
  Lines              ?         2           
  Branches           ?         0           
===========================================
  Hits               ?         2           
  Misses             ?         0           
  Partials           ?         0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

zhwesky2010

LGTM

luotao1 · 2025-11-14T10:13:15Z

@zade23 需要解决下流水线问题

zade23 · 2025-11-14T10:35:29Z

/re-run all-failed

zade23 · 2025-11-15T08:00:35Z

/re-run all-failed

zade23 · 2025-11-15T11:53:50Z

关于CI

Static-Check

API签名发生了变化，但没审批。

# 旧签名
paddle.Tensor.log10(x, name)
paddle.Tensor.log1p(x, name)

# 新签名（增加了out参数）
paddle.Tensor.log10(x, name, *, out=None)
paddle.Tensor.log1p(x, name, *, out=None)

Slice Test

~~失败的测试用例：~~

- Getitem - forward - Slice - Tuple of Slices - float16 - paddle: -16.58%
- SetitemTensor - forward - Slice - Tuple of Slices - float32 - paddle: -14.01%
- Getitem - forward - None - Combined with Integers for Expansion - float16 - paddle: -11.59%
... (其他slice相关测试)

~~我的改动应该不涉及slice操作~~

该CI已通过

zade23 · 2025-11-15T11:53:59Z

/re-run all-failed

…addlePaddle#76381) * sink log10 and log1p into c++ * Update test/legacy_test/test_activation_op.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update test/legacy_test/test_activation_op.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

sink log10 and log1p into c++

67c1ad9

Copilot AI review requested due to automatic review settings November 12, 2025 09:50

paddle-bot Bot added the contributor External developers label Nov 12, 2025

Copilot started reviewing on behalf of zade23 November 12, 2025 09:50 View session

Copilot finished reviewing on behalf of zade23 November 12, 2025 09:52

Copilot AI reviewed Nov 12, 2025

View reviewed changes

zade23 and others added 5 commits November 12, 2025 18:05

Merge branch 'PaddlePaddle:develop' into log10_log1p

3913159

Merge branch 'PaddlePaddle:develop' into log10_log1p

a755137

Merge branch 'PaddlePaddle:develop' into log10_log1p

1a2a6c8

Update test/legacy_test/test_activation_op.py

565debd

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update test/legacy_test/test_activation_op.py

dc9312d

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Nov 13, 2025

luotao1 assigned luotao1 and zhwesky2010 Nov 13, 2025

luotao1 changed the title ~~[API compatibility No.109、110 ] sink log10 and log1p into c++~~ [API compatibility No.109、110 ] sink log10 and log1p into c++ -part Nov 13, 2025

zhwesky2010 changed the title ~~[API compatibility No.109、110 ] sink log10 and log1p into c++ -part~~ [API compatibility No.109、110 ] sink log10 and log1p into c++ Nov 13, 2025

zhwesky2010 added the API Compatibility label Nov 13, 2025

zade23 mentioned this pull request Nov 13, 2025

[API Compatiblity No.109-110] add log10 and log1p to NO_NEED_CONVERT - part PaddlePaddle/PaConvert#755

Closed

zhwesky2010 changed the title ~~[API compatibility No.109、110 ] sink log10 and log1p into c++~~ [API compatibility No.109、110 ] sink log10 and log1p into c++ -part Nov 13, 2025

luotao1 changed the title ~~[API compatibility No.109、110 ] sink log10 and log1p into c++ -part~~ [API Compatibility No.109、110 ] sink log10 and log1p into c++ -part Nov 13, 2025

luotao1 mentioned this pull request Nov 13, 2025

【启航计划】PaddlePaddle API兼容性增强 #76301

Open

Merge branch 'PaddlePaddle:develop' into log10_log1p

85e4c64

zhwesky2010 approved these changes Nov 14, 2025

View reviewed changes

Merge branch 'PaddlePaddle:develop' into log10_log1p

7c58061

luotao1 assigned SigureMo Nov 18, 2025

luotao1 requested a review from SigureMo November 18, 2025 03:48

SigureMo approved these changes Nov 18, 2025

View reviewed changes

luotao1 added the skip-ci: static-check label Nov 18, 2025

luotao1 merged commit a774636 into PaddlePaddle:develop Nov 18, 2025
181 of 196 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[API Compatibility No.109、110 ] sink log10 and log1p into c++ -part#76381

[API Compatibility No.109、110 ] sink log10 and log1p into c++ -part#76381
luotao1 merged 8 commits intoPaddlePaddle:developfrom
zade23:log10_log1p

zade23 commented Nov 12, 2025 •

edited

Loading

Uh oh!

paddle-bot Bot commented Nov 12, 2025

Uh oh!

CLAassistant commented Nov 12, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 12, 2025

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented Nov 12, 2025 •

edited

Loading

Uh oh!

zhwesky2010 left a comment

Uh oh!

luotao1 commented Nov 14, 2025

Uh oh!

zade23 commented Nov 14, 2025

Uh oh!

zade23 commented Nov 15, 2025

Uh oh!

zade23 commented Nov 15, 2025 •

edited

Loading

Uh oh!

zade23 commented Nov 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

zade23 commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Category

PR Types

Description

Uh oh!

paddle-bot Bot commented Nov 12, 2025

Uh oh!

CLAassistant commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

zhwesky2010 left a comment

Choose a reason for hiding this comment

Uh oh!

luotao1 commented Nov 14, 2025

Uh oh!

zade23 commented Nov 14, 2025

Uh oh!

zade23 commented Nov 15, 2025

Uh oh!

zade23 commented Nov 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

关于CI

Static-Check

Slice Test

Uh oh!

zade23 commented Nov 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

zade23 commented Nov 12, 2025 •

edited

Loading

CLAassistant commented Nov 12, 2025 •

edited

Loading

codecov-commenter commented Nov 12, 2025 •

edited

Loading

zade23 commented Nov 15, 2025 •

edited

Loading