Change loading text if we call show function and loading dialog exists#23
Open
javierClavei wants to merge 44 commits intoPaldom:masterfrom
Open
Change loading text if we call show function and loading dialog exists#23javierClavei wants to merge 44 commits intoPaldom:masterfrom
javierClavei wants to merge 44 commits intoPaldom:masterfrom
Conversation
|
+1 |
1 similar comment
|
+1 |
|
this is a good update to the plugin, is there any plan to merge it? +1 |
|
applied this fix in repo https://github.com/greybax/cordova-plugin-native-spinner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think is not necessary show more than one loading dialog and I think is interesting change the text to show the progress for example.