Skip to content

Only log endpoint open & close once#1777

Open
Warriorrrr wants to merge 2 commits into
PaperMC:dev/3.0.0from
Warriorrrr:fix/log-endpoint-open-close-once
Open

Only log endpoint open & close once#1777
Warriorrrr wants to merge 2 commits into
PaperMC:dev/3.0.0from
Warriorrrr:fix/log-endpoint-open-close-once

Conversation

@Warriorrrr
Copy link
Copy Markdown
Member

When reuse-port is enabled in the config, the listening on and closing endpoint messages are logged for every endpoint that is opened/closed, even when as far as I can tell, the address being logged is always the same

Fixes #1755

When reuse-port is enabled in the config, the listening on and closing endpoint messages are logged for every endpoint that is opened/closed, even when as far as I can tell, the address being logged is always the same
@WouterGritter
Copy link
Copy Markdown
Contributor

Maybe a good opportunity to log on how many endpoints we are listening/closing on? Or is that too verbose?

@Warriorrrr
Copy link
Copy Markdown
Member Author

I 50/50 considered mentioning that in the pr description, but wasn't sure how useful it is to know the number of open endpoints

@WouterGritter
Copy link
Copy Markdown
Contributor

I 50/50 considered mentioning that in the pr description, but wasn't sure how useful it is to know the number of open endpoints

That is something that's lost with this PR. It's cumbersome but you would be able to count the number of logs for this. Maybe only log the number if it's > 1?

@R00tB33rMan
Copy link
Copy Markdown
Contributor

When reuse-port is enabled in the config, the listening on and closing endpoint messages are logged for every endpoint that is opened/closed, even when as far as I can tell, the address being logged is always the same

Fixes #1755

I remember creating a similar issue report and assume this might actually be intentional when digging deeper into logs: #1535 (comment)

Maybe this should be reapproached?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate port opening/closing messages in Velocity 3.5.0-SNAPSHOT (git-d11511c1-b584)

3 participants