Skip to content

Feature/update from ugrid conventions #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fluidnumerics-joe wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Feature/update from ugrid conventions #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9327231
Fix bug in download_all
fluidnumerics-joe Feb 3, 2026
5e2d60d
Change to convert.* methodology for fesom2 benchmark
fluidnumerics-joe Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion benchmarks/fesom2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import numpy as np
import uxarray as ux
from parcels import (
convert,
Field,
FieldSet,
Particle,
Expand Down Expand Up @@ -44,7 +45,8 @@ def time_load_data(self,npart,integrator):

def pset_execute(self,npart,integrator):
ds = _load_ds(self.datapath)
fieldset = FieldSet.from_fesom2(ds)
ds = convert.fesom_to_ugrid(ds)
fieldset = FieldSet.from_ugrid_conventions(ds)

lon = np.linspace(2.0,15.0,npart)
lat = np.linspace(32.0,19.0,npart)
Expand Down
2 changes: 1 addition & 1 deletion parcels_benchmarks/benchmark_setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ def download_all(
dataset_folders: dict[str, Path] = {}
for dataset_name in datasets.keys():
folder = download_example_dataset(dataset_name, manifest_path=manifest_path, data_home=data_home)
dataset_folders[dataset] = folder
dataset_folders[dataset_name] = folder
return dataset_folders

@app.command("add-dataset")
Expand Down