Conversation
erikvansebille
left a comment
There was a problem hiding this comment.
Nice cleanup! But I now understand that a CTD can only be run with BGC variables; correct? So no option to use only a subset of the sensors? Would that be useful and/or authentic?
| description=( | ||
| "Sensors fitted to the BGC CTD. " | ||
| "Supported: OXYGEN, CHLOROPHYLL, NITRATE, PHOSPHATE, PH, PHYTOPLANKTON, PRIMARY_PRODUCTION. " | ||
| "Sensors fitted to the CTD. Supported: TEMPERATURE, SALINITY, OXYGEN, CHLOROPHYLL, NITRATE, PHOSPHATE, PH, PHYTOPLANKTON, PRIMARY_PRODUCTION. " |
There was a problem hiding this comment.
Is there still a possibility to use only the physical variables? Or will a ctd now always also use bcc?
for more information, see https://pre-commit.ci
Ah yes it is indeed possible to only use the physical variable sensors still (or any subset/combination of phys/bgc variables)! Which sensors are on/off is configurable in the instrument config section of the expedition YAML. The docs and Related and maybe useful to know: this doesn't mean user can add a 'non-sensical' sensor to an instrument. E.g. you can't add a BGC variable to an ADCP. There are still controls on which sensors an instrument can take. |
Now that we have implemented the sensors refactoring in #328, the
CTDandCTD_BGCinstruments can nicely be consolidated to oneCTDinstrument which supports both physical and biogeochemical variable sampling (configurable via the expedition YAML).This PR also updates the documentation to reflect these changes and updates/adds relevant tests.
Closes #260