Merged
Conversation
- By default uses migration topology with budnle-1 topic - Can override the single topic via connection string - Can provide custom topology options via ServiceControl.Transport.ASBS/Topic setting
…opic explicitly specified
- Connection string has precedence over custom config
Member
Author
|
@danielmarbach I pushed the latest approach that takes advantage of |
src/ServiceControl.Transports.ASBS/ServiceControl.Transports.ASBS.csproj
Outdated
Show resolved
Hide resolved
src/ServiceControl.Transports.ASBS/ServiceControl.Transports.ASBS.csproj
Outdated
Show resolved
Hide resolved
Contributor
|
Approving but we should probably wait with merging until we have the final version right? |
danielmarbach
approved these changes
Feb 19, 2025
Member
That is a HUGE breaking change. Please don't make that the default! It would break any subscribers to SC events if these would not be using the new topology. As SC needs to be wirecompatible with prior Core versions you can't make this the default without explicit consent. Another option is explicit opt-in during upgrade OR make hybrid the default. Please don't do a hidden breaking transport change. |
SzymonPobiega
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azure Service Bus transport 5 introduces new event delivery topology using topic-per-type approach. This change affects how ServiceControl publishes integration events.
Behavior:
TopicNameproperty, ServiceControl uses the migration topology that allows publishing events in the way they can be processed by older versions of the transportServiceControl.Transport.ASBS/Topologysetting. This option allows mixing topic-per-event and single-topic approaches if there are subscribers that use both versions