Check that server version is greater than or equal to the client#5111
Merged
ramonsmits merged 3 commits intomasterfrom Sep 10, 2025
Merged
Check that server version is greater than or equal to the client#5111ramonsmits merged 3 commits intomasterfrom
ramonsmits merged 3 commits intomasterfrom
Conversation
bording
force-pushed
the
ravendb-version-check-server-higher
branch
from
9ef2931 to
d39a2cd
Compare
bording
force-pushed
the
ravendb-version-check-server-higher
branch
from
d39a2cd to
ea8e0bb
Compare
Member
Author
|
Thanks @bording, that is actually much simpler than doing all the parsing I did in the 1st commit. |
bording
changed the title
bording
approved these changes
Sep 9, 2025
bording
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following prior PR does a fixed minor/major comparison between client and server:
However, the PR description hints that it follows the RavenDB guidance:
This PR fixes this. It parses the version numbers and then compares by only using the
Major.Minor.