Improve remote instance serialization and exception logging in unattended installation#5336
Merged
danielmarbach merged 2 commits intomasterfrom Mar 4, 2026
Merged
Improve remote instance serialization and exception logging in unattended installation#5336danielmarbach merged 2 commits intomasterfrom
danielmarbach merged 2 commits intomasterfrom
Conversation
danielmarbach
force-pushed
the
unattended-installation
branch
from
82a11b4 to
74343f6
Compare
danielmarbach
changed the title
danielmarbach
changed the title
jpalac
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors JSON serialization for
RemoteInstanceSettingobjects to use source-generated context, and improves error logging throughout the unattended installer classes by logging the full exception object instead of just the message. These changes enhance both performance and troubleshooting capabilities.Serialization improvements:
RemoteInstanceConverterto use source-generatedRemoteInstanceContextfor JSON serialization and deserialization, replacing manualJsonSerializerOptionsconfiguration. This improves performance and maintainability of serialization logic.Error logging enhancements:
UnattendServiceControlInstaller,UnattendAuditInstaller,UnattendMonitoringInstaller) to log the full exception object instead of only the message, providing more detailed information for troubleshooting. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]