Skip to content

Consolidate platform capability status checks into PlatformCapabilitiesStore#2892

Merged
johnsimons merged 1 commit intomasterfrom
john/refresh-bug
Mar 16, 2026
Merged

Consolidate platform capability status checks into PlatformCapabilitiesStore#2892
johnsimons merged 1 commit intomasterfrom
john/refresh-bug

Conversation

@johnsimons
Copy link
Member

@johnsimons johnsimons commented Mar 16, 2026

Refactors the auditing and monitoring status checks to use a single auto-refresh mechanism. This moves the state and logic for hasSuccessfulMessages and hasMonitoredEndpoints out of their respective stores and into the PlatformCapabilitiesStore, reducing the number of concurrent refresh timers. Additionally, introduces a dedicated AuditClient to encapsulate audit-related API requests.

This PR fixes:

Reviewer Checklist

  • Components are broken down into sensible and maintainable sub-components.
  • Styles are scoped to the component using it. If multiple components need to share CSS, then a .css file is created containing the shared CSS and imported into component scoped style sections.
  • Naming is consistent with existing code, and adequately describes the component or function being introduced
  • Only functions utilizing Vue state or lifecycle hooks are named as composables (i.e. starting with 'use');
  • No module-level state is being introduced. If so, request the PR author to move the state to the corresponding Pinia store.

Refactors the auditing and monitoring status checks to use a single auto-refresh mechanism. This moves the state and logic for `hasSuccessfulMessages` and `hasMonitoredEndpoints` out of their respective stores and into the PlatformCapabilitiesStore, reducing the number of concurrent refresh timers. Additionally, introduces a dedicated AuditClient to encapsulate audit-related API requests.
@warwickschroeder
Copy link
Contributor

Could we document these patterns and place in the docs folder? Additionally are there any lint rules or tests we could write to prevent issues like the one thats linked?

@dvdstelt dvdstelt added this to the 2.6.1 milestone Mar 16, 2026
@dvdstelt
Copy link
Member

dvdstelt commented Mar 16, 2026

This definitely does NOT fix:

It does fix issues, but we still need:

@dvdstelt dvdstelt added the Type: Bug Type: Bug label Mar 16, 2026
@johnsimons johnsimons merged commit 435bc3d into master Mar 16, 2026
5 checks passed
@johnsimons johnsimons deleted the john/refresh-bug branch March 16, 2026 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Bug Type: Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants