Consolidate platform capability status checks into PlatformCapabilitiesStore#2892
Merged
johnsimons merged 1 commit intomasterfrom Mar 16, 2026
Merged
Consolidate platform capability status checks into PlatformCapabilitiesStore#2892johnsimons merged 1 commit intomasterfrom
johnsimons merged 1 commit intomasterfrom
Conversation
Refactors the auditing and monitoring status checks to use a single auto-refresh mechanism. This moves the state and logic for `hasSuccessfulMessages` and `hasMonitoredEndpoints` out of their respective stores and into the PlatformCapabilitiesStore, reducing the number of concurrent refresh timers. Additionally, introduces a dedicated AuditClient to encapsulate audit-related API requests.
This was referenced Mar 16, 2026
PhilBastian
approved these changes
Mar 16, 2026
warwickschroeder
approved these changes
Mar 16, 2026
Contributor
|
Could we document these patterns and place in the docs folder? Additionally are there any lint rules or tests we could write to prevent issues like the one thats linked? |
dvdstelt
approved these changes
Mar 16, 2026
Member
|
This definitely does NOT fix: It does fix issues, but we still need: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the auditing and monitoring status checks to use a single auto-refresh mechanism. This moves the state and logic for
hasSuccessfulMessagesandhasMonitoredEndpointsout of their respective stores and into the PlatformCapabilitiesStore, reducing the number of concurrent refresh timers. Additionally, introduces a dedicated AuditClient to encapsulate audit-related API requests.This PR fixes:
Reviewer Checklist