This repository was archived by the owner on Jun 3, 2024. It is now read-only.
Completely stub all classes in god-classes #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Contributor
|
AFAICT All functionality that these classes had before is still present. Maybe add a comment at the top explaining not to try to use them in other modules, part of the appeal of codegen for me was that it made it pretty clear that the classes weren't meant for us. |
Contributor
Author
|
huh, i thought they all ready had comments at the top. at least a couple of them do. I'll add the comments. I'm still open to switching back to codegen if everyone else prefers codegen, but my personal scales have been tipped away from it and the other people I've asked have been non-committal, so I just. made a decision. |
TheGlitch76
approved these changes
Nov 21, 2020
Member
TheGlitch76
left a comment
TheGlitch76
left a comment
There was a problem hiding this comment.
concept looks good, will merge later
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: current commit only stubs ForgeHooksClient, just to get an idea of what this would look like.Alternative to #202, basically a dead simple approach to reducing conflicts by adding more context.
Somewhat tedious to setup, but there's no underlying complexity that could bite us in the ass later.
Also introduces an annotation to mark stubbed items so that we can detect them in other tools (like patcher?)