Fix HTTP/2 response headers parsing #1668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HTTP/2 spec requires header field names to be lowercase. This change makes PoB agnostic about the used HTTP version by changing the pattern to be case-insensitive.
Contributor
|
Don't worry about the spell-checker failing, I've just added an exception. |
LocalIdentity
approved these changes
Dec 22, 2025
LocalIdentity
merged commit 2e84d43
into
PathOfBuildingCommunity:dev
1 of 3 checks passed
github-actions bot
pushed a commit
to PathOfBuildingCommunity/PathOfBuilding
that referenced
this pull request
Dec 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HTTP/2 spec requires header field names to be lowercase. This change makes PoB agnostic about the used HTTP version by changing the pattern to be case-insensitive.
This doesn't affect the official Windows version of PoB (yet) because it bundles a
libcurllibrary that is not compiled with HTTP/2 support. My main motivation behind this fix is meehl/rusty-path-of-building#20.I know third-party runtimes are not officially supported but i still hope to see this merged because i feel like PoB shouldn't make any assumptions about the HTTP version being used. If the bundled
libcurllibrary is ever compiled with HTTP/2 support you'll most likely run into the same problem.