Skip to content

Add support for thorns crit and ignore armour passives#1775

Closed
DS-Koala wants to merge 2 commits intoPathOfBuildingCommunity:devfrom
DS-Koala:ds-koala/support-thorns-crit
Closed

Add support for thorns crit and ignore armour passives#1775
DS-Koala wants to merge 2 commits intoPathOfBuildingCommunity:devfrom
DS-Koala:ds-koala/support-thorns-crit

Conversation

@DS-Koala
Copy link

@DS-Koala DS-Koala commented Mar 6, 2026

Fixes unsupported thorns nodes.

Description of the problem being solved:

Adds support for passive nodes that grant:

  • % increased Thorns Critical Damage Bonus
  • +% to Thorns Critical Hit Chance
  • Thorns Damage has % chance to ignore enemy armour

Steps taken to verify a working solution:

  • Added the affected passive nodes in a build using Caltrops
  • Verified the passive text no longer appears in red ("Not supported in PoB yet")
  • Confirmed that allocating % increased Thorns Critical Damage Bonus updates Crit Multiplier and damage values
  • Confirmed that allocating +% to Thorns Critical Hit Chance updates Crit Chance values
  • Confirmed that allocating Thorns Damage has % chance to ignore enemy armour increases damage against armoured enemies
  • Verified that existing % increased Thorns Damage nodes still function correctly
  • Regenerated ModCache.lua after parser updates

Link to a build that showcases this PR:

https://pobb.in/p7hHYhLQYNuX

Before screenshot:

BeforeThorns

After screenshot:

AfterThorns

@Nightblade Nightblade added the enhancement New feature, calculation, or mod label Mar 6, 2026
@DS-Koala DS-Koala closed this Mar 6, 2026
@DS-Koala DS-Koala deleted the ds-koala/support-thorns-crit branch March 6, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants