Skip to content

Add support for Expand#1818

Open
Peechey wants to merge 2 commits intoPathOfBuildingCommunity:devfrom
Peechey:feature/expand-support
Open

Add support for Expand#1818
Peechey wants to merge 2 commits intoPathOfBuildingCommunity:devfrom
Peechey:feature/expand-support

Conversation

@Peechey
Copy link
Copy Markdown
Contributor

@Peechey Peechey commented May 8, 2026

Description of the problem being solved:

Adding support for the Seal Support: Expand by updating CalcOffense's calcAoE function with seal logic. In order to differentiate the Seal logic for AoE vs Damage from something like Unleash, I've added a flag to Seal skills to keep them separated. Expand has the flag "AreaSeal" and Unleash has "DamageSeal". PR #1811 would need the same DamageSeal added to Zarokh's Revolt and I will update that if we go forward with this.

I'm also updating the source name for the damage/aoe mods from seals to be dynamic instead of the hardcoded "Unleash" and what would be a hardcoded "Expand." Zarokh's Revolt from 1811 needs this change anyways to be more accurate and GGG could introduce a Revolt version of Expand in the future e.g.

I couldn't test 100% in game as it doesn't have the new radius in the tooltip, but my assumption is Expand gives 90% inc AoE at max seals.

Steps taken to verify a working solution:

  • Validate increased AoE with Expand
  • Validate Seal outputs
  • Validate Seal Gain passives affect Expand

Link to a build that showcases this PR:

eNq1W1934rYSf24_BYdnEjDmX3qS9hBIdjkn2XAh2W2f9ii2AN3IFrXlJPTT3xlJNobERCK9fcjKYn4zmpE0mhmp53-8Rrz2TJOUifii7p226jUaByJk8fKi_nB_fTKo__H7r-dTIld3i8uMcfyl_fuvv5yrjxqnz5QDsFevRYTFcxE8UfklEdkaOuu1gJM0_UYielGfkXhJk3qNpAGNw9H2h28ipvWaJMmSyu_5SFo_Eb0iCQkkTW5QyjCT4laEgJBJBohnRl_09-R2eje7r8OofjmfcrKhyVwSWUvhz0V9CNqRJf3KJEAIz4D-zDvt9urNg_SXWZLKMYmgaYebrykNC1Kvimya0KvFggaSPdNRwuRoReJgK8JrVwGdiW8zLtmaMzS6AVTSf33Lu9WqIr4XkvDxdG5nF00tttav5PuDydUlByta80bEZBkzSZ0gU8FSETtrUAZUKjHKOIctYkU7oylNnolku4Op5i2iRxY72GdOCR8JwUPxEm9n9tTvn_ley-90Bu3-QewteS1gfqV5WESBEOnTgrpz6pWkDCo3W0LJ3UJviBkJWZbeUpnQMp9KubckJiORbhfWYHCIdEoTcDxyB9H6ADCngQBf5SzkfWiltBu2oPaUTooYgOtojtPjam5L58z4uAHNwHvbUc5Fxi0p5dafDiod6phud47XraKaxFuB_Wov8XeZzuv2q4U-C3QmHytxn7DHTFILQvR9V1-nWzfQap_2Pb_rd9r9TqtS_-lqk7JAeRAWZRGcL_fkiW5H1qk-u27YciVj8KFV2Ha_0qDXLKFHwEbgIo-BrYhIj9BwTJKnmKap7QkBHt8agbvXZgwQrgS_IfEkDgr67iGuD3FiRmM3iws6g62K0dQjp7aQrRCz420CEi1rSWMjcGNnphtKg9UXiFpnxGYroH_fjsbzD1oWicuWPcj1Hcse4L-LcDATAt83U-e0ewjkaKj5miXMakSa8j317TEOBriKabLczFeM8tDi0ClR5xYbkbWN_rAAymirhbArzmkxl6GOc4UnpKu0Z5KWD5n-YTtoajsTPJOQ7uUh1auZQqrghJgm4r-YeHE3GKjBuTviSGljuuAIEziBcAhaI2wFDJNIZInlKtbEVpOXn_g6Z57RMAvsYpEiHb7kIniyVaNAKWM7QYdSkuBpLMKl24w6IXbHN8_Wa3BYuBNsGWAoA8c_K8WkJ10L6jvYxVZuCoMeewFbamsBRSBnL2UPYq8LRmJ7YmyIrQUU03kLXjKC80aVe26FRcVnB_FjBQ7hIQUN50-M863g6jx3iicdLJn38-PKBZFxblVUUISWxY2peAF7rbBUl7pRW1USrhMa_7Ox5r9DbiXgKg6zBLeftYx9xHtiLrPFIq0FInok8gYW1UW9XnuEvrwdZElKzYdGYMmEgzsYE0lqqaqZXjMuaTIGKpSGI6qFJp37ThJGYumpiupeZ1t1ppQkwQpFXBPOH8G7odxtrxF83lRFW2yNCA9SNZZJvM5kLVal2BTX5M84ix6xaKj_3a7sMmXE0uAnKokVWBAlE1Uxvrq-vhrdT75fGchcH2VgHM7JOqXhRX1BeIqI7DHVP17UvzP6orbDmErCsIrEgFD1zCmebU7cFA7Ssbx4i7y2ny6crl5pgmfwD7BjwqgZV_HlPCg9BAyzcAFoblgZdWGkD68RSaUO8JSlVOnZhQvWh4062HTCTqI14UayaTtbQm7WNIUAgy1YgLutPOX38Jvuc7JLANuMBJtivs0568JDFZ81A910AeuiskabtpNVVRnbWFW3XeBjGhCju266gIucQcTqmgS5FH1OnL6JWC1y2DRDxvHUMzN7xWnR4cLwTq5oog9fw-kWPE_e4bhxdNHL8Cl9O9lK1VeUhbDlAtUFBKUDtpw2jUmp9W5nrlt2N_FV81HucWGl4yZjQxNxOU2DST_UFOi2kyZ58qmUMB9OG0X54OGzYKGOw9WW2et0cxpwfn-ejUou_gU2Rfr4eV7XnKRPZqZNuxKur2TL6AdIfZncfI4J7rHPccCt9jkOGPlFR6NnRQwyOxh-vC93mXur_MMBX4SuR3PQAfbRcBX_W6KrXD-sZ8x9Sr6_6HHynzKLx2CN7cawY_VWKTWqPffxOV76WPyXFNX73dxEbB2A7nBmBMf41yJQPJZTkTp_pYTj5bvgn2P45sbFmtk725MGIluTOMy53e1G58daT8gUmKp0a4zl1fRTo4TTOtoc4nPezBO685GIF2xZI_qFifqYU4lZnJJX9NQkk5yqE4Nk3MQWmkjlwQFdCR7SxCR8FIeAVaYpWjxPDU0K_B5gHgjIPueYraRvcslKCcX5XgC8_P6tEqPqOXm2V4xs0KuGRcXTGHQMMcX6PuxBvrEfqHqStCXPb4KrB1l6vpODuhYYLKn-oETd_u0bs936iEGpxFcI_QiUR2iFaq2eb2NKlRdvHtJjrGkeT-Xk_dZHg8wLJQ7GwMW7v0rOelaLa9-GH45O18BhS6tXb2XFLGbMdocVACetthM2ZuCZ4YiXX-APCSkaKHTYAXmt1t2o5dq29bp8U052R1r7rhXE9A6uK2VLxu8WKuABmIraLGClvcMwFKChkjkSWSznlC9KTGxcxRsXeMAuIY1EfC2S6I2WB0CjFVbk7M3yzlIbRpFwXGe7F0vvLDM4_PJDTR-F6gub3wSk90iC3fnH-SRai0TW6Cv-MyWJ3ORnuDpK7xNKzfGJd2DFyYkftYikkiYbU4DQVVZ8j0SSzXD7sHUCR2nMuHn_il8tGLcIaYqrtdM9a_jeWbfV6A789lmj3Rm0u42O3-_0Gv7A6_iNbq_X9Rq9dsf3GnAAttuNbr_VbnR6Lb_TaJ91-mcNz-94XgP--ADyul4f2PQ6_UbP8856jUG3dwZcQFTD6wFs59mtGY8EPUvvbTs5DbjVzSQGLWPCkTTXotTVNmHCw-xGNX5ZSblOf2s2X15eTtdErsSCvjJOTwMRNdcABlueqOLyCUptDuG_y-VweOX_c9c548sTkjA-_RnOf04XN4H4MUum82ATtP7qfP-LvnrL2cngdvJnTPoPl7cAvVDCm7n0c_3qODXLCCO4hIV64uG7KPTkP2C1-pueDG2t3IpqStDQymZmRrTRtbn1TOkJ0ObW81Uyt5pSCKZiaURgyf41b5shNnfGeN7EpaWWLq49bKhCaApIFZt9odGNfmcdw44tHlXV81WqC-XS3A_kkP9kBBNwNdcprHToSi834-n8Gos-e69JdwiKEHQlXvDmUv-GdVnQYXhzY_aDEbsTOKpO9RR8uB2bik3V6PZ-UH0sDngW0klsrqyKgJqTR9QZX6TjE6I8MjbTCiMyP3zh4pHwdj5qdB16404CWvsmnsk-B3W3AyOfxDA1ZnBqu5b5ee8RG7pnffmCWwFkaBEBem2l0N9lw6OaJTp9wVTP381D0FJb0ggJbqkkIZGkOZEwD02cjKYyErRyIU173a9eMav5f2quJZj18aH-hk6D9qzgHTZCsQKNTg5WeIg5JemqZIY8Wfv37GBkOBrCoI60RK5X7k_UQjG-xGxL5U-0H1GHHrIxDgPbub9Qexz0y0_oAPe4VjtLqX5sC_nHWsQKoc2nrwM1lwNku56Bi_zyUBPW2kAAPKaP4Mhxm-OHPpuabyCXItzUitqxLQrm8VmVVOzFCOlCP4Ogsua5AtquAN8BYIzr1eYv-LDBGqfKnE5Du6FuqqjiqZO18oVynC4uki6pKoHYkg8d2WvVXYw1hOCZSsfZ8Jxt5Dsq3T5iJTpAvlIefaT1edN4Hv2UIoHMda5eOvygmOeluh6m_B22VIBfg4zuZRg-Y8ngXgieFi4KYjDJYmIup_BFDlmvIQp-kxLgIwXzpGIuIf2AJhD_I0T0F1abTv1Wp93v-13f77R1v4nZfP3150X9pNc57cDPfq911u4OBoe8L8g9b7753-7-B1iPA9I=

Before screenshot:

image

After screenshot:

image image

@Peechey Peechey added the enhancement New feature, calculation, or mod label May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant