Skip to content

[pob1-port] Add build comparison tab#1830

Draft
vaisest wants to merge 6 commits into
PathOfBuildingCommunity:devfrom
vaisest:comparison-port
Draft

[pob1-port] Add build comparison tab#1830
vaisest wants to merge 6 commits into
PathOfBuildingCommunity:devfrom
vaisest:comparison-port

Conversation

@vaisest
Copy link
Copy Markdown
Contributor

@vaisest vaisest commented May 11, 2026

Changes from PathOfBuildingCommunity/PathOfBuilding#9543

Description of the problem being solved:

Steps taken to verify a working solution:

Tested combinations of the following builds:

Seems most of it is directly compatible with pob2, but various things are hidden behind different variables. These fixes mostly focus on fixing those mistakes. Skill sets were also added to the calcs tab (I honestly don't know what these are)

Todo:

  • test

@vaisest
Copy link
Copy Markdown
Contributor Author

vaisest commented May 11, 2026

As expected, there are issues with the mod matching. Namely, unique mods (not included in querymods.lua) and local mods. For example to accuracy rating ends up matching a global mod, even though it's usually a local mod: +# to accuracy rating (local). This issue is actually also present on the pob1 comparison tab too.

I'd prefer to fix this in my trader PR, since it focuses on similar issues. The purchase option seems to work fine otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants