Fix persistent buff supports of the same category not stacking#1833
Open
Peechey wants to merge 3 commits into
Open
Fix persistent buff supports of the same category not stacking#1833Peechey wants to merge 3 commits into
Peechey wants to merge 3 commits into
Conversation
…ng as they're on different persistent skills
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1768
Description of the problem being solved:
Persistent buff supports like Direstrike I and II can stack so long as they are supporting separate skills. The issue was the Buff effectName was the same across these supports so we were overwriting. Updating to have the Buff effectName include the Tier.
Also fixed Direstrike supports not have the LowLife condition.
Added a test because I guess I do that now.
Supports affected:
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: