Fix outdated SkillType.Totem reference in Phase Run #9388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit [1b07714](PathOfBuildingCommunity@1b077141) ("Update SkillTypes to Actuals"), `SkillType.Totem` was renamed to `SkillType.SummonsTotem`. However, one reference in [Phase Run's statMap](https://github.com/PathOfBuildingCommunity/PathOfBuilding/blob/master/src/Data/Skills/act_dex.lua#L11295) was missed during that update. This PR updates that reference to use the correct name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SkillType.TotemtoSkillType.SummonsTotemin Phase Run's statMapDetails
While working on importing the PoB rules in Rust with strict validation of SkillType references, it flagged this specific issue.
In commit 1b077141 ("Update SkillTypes to Actuals"),
SkillType.Totemwas renamed to
SkillType.SummonsTotem. However, one reference in Phase Run'sstatMap was missed during that update.
This PR updates that reference to use the correct name.