Preserve cluster jewel notables when changing enchantment#9513
Open
EtherealCarnivore wants to merge 2 commits intoPathOfBuildingCommunity:devfrom
Open
Preserve cluster jewel notables when changing enchantment#9513EtherealCarnivore wants to merge 2 commits intoPathOfBuildingCommunity:devfrom
EtherealCarnivore wants to merge 2 commits intoPathOfBuildingCommunity:devfrom
Conversation
Keep currently-selected affixes in the dropdown even when they can't naturally spawn on the new base. In 3.28 you can change a cluster jewel's enchantment without losing existing mods, so the affix list filter now skips the spawn weight check for whatever mod is already selected in each slot.
Grey out notables in the affix dropdown that only appear because they are currently selected but have zero spawn weight on the active enchantment. This makes it clear which mods were carried over from a different cluster jewel enchant.
Contributor
Author
|
Update: Added a Discussed with LocalIdentity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3.28 adds a currency that changes a cluster jewel's enchantment without touching existing mods. Right now, changing the enchant in the crafting UI re-validates all affixes against the new skill tag and drops any that can't roll on the new base.
Changed the affix list filter in
UpdateAffixControlto keep the currently-selected mod in each slot even if its spawn weight is zero for the new enchant.Tested by crafting a Large phys cluster with notables, switching the
enchant to spell damage, and confirming the notables stay.
Full testsuite passes (194/194, the one failure in
TestTradeQueryCurrency_specis pre-existing).