Update Resonating Shrine to grant max charges instead of per-charge bonuses#9518
Open
EtherealCarnivore wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Open
Conversation
…onuses 3.28 changed Resonating Shrine from granting bonuses per charge type to granting +1 maximum power, frenzy and endurance charge. Charge generation on hit/kill is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3.28 changed Resonating Shrine. Instead of granting bonuses per power/frenzy/endurance charge, it now grants +1 to maximum of each charge type. Charge generation on hit and kill is unchanged.
Old behaviour (removed):
New behaviour:
Updated CalcPerform.lua (mods) and ConfigOptions.lua (tooltip). Shrine effect scaling still applies via
shrineEffectMod, same as other shrines.Full test suite passes (194/194, the 1 failure is a pre-existing trade query ordering flake).