Cancel power report calcs through toast message#9522
Draft
Blitz54 wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Draft
Cancel power report calcs through toast message#9522Blitz54 wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Blitz54 wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Currently the dismiss button on the power report toast message doesn't really do anything. It hides the message for a few frames, but it instantly shown again with the new percentage.
I figured changing the button to be "Cancel" for the power report makes sense. Clicking Cancel will toggle the node power box on the tree tab.
Currently, enabling the node power calcs, then switching to a different tab (like Items) will stop the power report. Clicking Cancel then will not stop the power report when returning to the Tree tab. So maybe there is a better way of doing this, but making this PR for now.
After screenshot: