Fix Enemy damage conversion mods scaling enemy damage#9527
Open
LocalIdentity wants to merge 1 commit intodevfrom
Open
Fix Enemy damage conversion mods scaling enemy damage#9527LocalIdentity wants to merge 1 commit intodevfrom
LocalIdentity wants to merge 1 commit intodevfrom
Conversation
When I added the fix for scaling enemy damage values by player and enemy conversion mods I forgot include the fix where only enemy skill damage conversion is affected by the phys conversion multiplier So mods like Shaper of Flames or Kaom's Binding were increasing the damage dealt by the enemy which was no longer the case in game
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9444
Description of the problem being solved:
When I added the fix for scaling enemy damage values by player and enemy conversion mods (#9372), I forgot to include the fix where only enemy skill damage conversion is affected by the phys conversion multiplier
So mods like Shaper of Flames or Kaom's Binding were increasing the damage dealt by the enemy, which was no longer the case in-game.
Link to a build that showcases this PR:
https://maxroll.gg/poe/pob/vjnj30og
Before screenshot:
After screenshot: