[WIP] Add support for Renaming, Copying, and Deleting Loadouts#9528
Open
Peechey wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Open
[WIP] Add support for Renaming, Copying, and Deleting Loadouts#9528Peechey wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Peechey wants to merge 1 commit intoPathOfBuildingCommunity:devfrom
Conversation
… for clean up and other comments
Peechey
added
wip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Initial impl for Renaming, Copying, and Deleting Loadouts. Also allows creating a New Loadout from current active sets. There are a lot of changes from over a year of off and on dev so I don't remember everything and I'm gonna comb through it over the next days. Getting eyes on for optimizations, improvements, testing, and other questions about dumb things I'm probably doing.
There is commented code I need to remove, unused variables likely, and more comments to add.
Steps taken to verify a working solution:
After screenshot:
Delete has a confirmation
