Add support for "Fleshrender" unique (and general poison stacking mechanics)#9533
Open
majochem wants to merge 10 commits intoPathOfBuildingCommunity:devfrom
Open
Add support for "Fleshrender" unique (and general poison stacking mechanics)#9533majochem wants to merge 10 commits intoPathOfBuildingCommunity:devfrom
majochem wants to merge 10 commits intoPathOfBuildingCommunity:devfrom
Conversation
Renamed for clarity as it is not actually a "doubling" effect
- parsing and logic for application of more than 1 additional poison per hit via "inflict X additional poisons on the same target ..." - parsing and logic for poison stack limit via "cannot poison enemies with at least X poisons on them" - adds parsing and logic for additional `CannotMultiplie` flag that will apply to Viper Strike of the Mamba as of 3.28
…at least 12 Poisons on them" Just setting `Condition:CanWither` flag for now, as actually checking for number of poisons seems overkill and eliminates too many edge cases
This is the counterpart to `ModStoreClass:Max()` and gives back the lowest modifier value. This makes sense for things like the poison stack limit, where neither "BASE" nor "OVERRIDE" would work for multiple mods
"MAX" already existed and was used, but was missing from `modSyntax.md`, so I added the explanation for both now
- Now shows active poison stack limit - Now shows what uncapped poison stacks would be (to gauge if you're close to being under cap) - Changed wording of "Capped to 1" for `Condition:SinglePoison` hint to "Assume non-Poisoned Enemy" because that is what it is actually used for
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Adds support for mods from the new 3.28 unique "Fleshrender"
Additional changes
DoublePoisonChancewas renamed toAdditionalPoisonChancebecause it's not technically "double""MIN"modType and correspondingModStoreClass:Min()function as counterpart to"MAX"andModStoreClass:Max()"MAX"and"MIN"tomodSyntax.mddocumenationPoisonStackLimitof1to Viper Strike of the Mamba viaSkillStatMapSteps taken to verify a working solution:
Witheredvia configAdditionalPoisonStackscorrectly interacts withAdditionalPoisonChance(can get e.g. 4.33 poison stacks)limit % poison stack per hit != 0(e.g. if limit is2and you apply4poisons with each hit, the effective limit is4CannotMultiplePoisonprevents additional poison stacksLimitations:
SkillStatMap.luaonce 3.28 gem data is availableCountand Full DPS (e.g. for Totem Builds), will not limit total poison stacks correctly and therefore inflate DPS (this has also already been the case for Viper Strike of the Mamba)xhitsLink to a build that showcases this PR:
Fleshrender Test Build
After screenshot:
Item with parsed mods

Poison Stack Breakdown
