ci: add pre-test checks with format, lint, and compile steps#11
ci: add pre-test checks with format, lint, and compile steps#11rootandroo wants to merge 2 commits into
Conversation
rootandroo
force-pushed
the
ci-pretest-checks
branch
from
a71455f to
2bc637e
Compare
|
You'll need to make PRs to format the backend and the frontend so that the checks pass the first time. |
| # - pull requests targeting main | ||
| # Does NOT fire on tag-only pushes or unrelated events. | ||
| on: | ||
| push: |
There was a problem hiding this comment.
Actually what's the benefit of having CI run on all pushes?
- Rename jobs: backend-ci → backend-pretest, frontend-ci → frontend-pretest - Backend: add Spotless format check, Checkstyle, and compile steps - Frontend: switch to pnpm, add typecheck, prettier, lint, and build steps - Trigger on push to any branch and PRs targeting main - Document trigger rules in workflow file
rootandroo
force-pushed
the
ci-pretest-checks
branch
from
2bc637e to
3143681
Compare
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| - name: Setup pnpm | ||
| uses: pnpm/action-setup@v6 | ||
| with: | ||
| node-version: "24" | ||
| version: 10.24.0 |
There was a problem hiding this comment.
Missing Node.js setup step. The original workflow explicitly installed Node.js v24 using actions/setup-node@v6, but the new workflow only sets up pnpm. The pnpm/action-setup action does not install Node.js - it only installs pnpm and requires Node.js to already be present.
While GitHub's ubuntu-latest runner includes Node.js by default, the version is not guaranteed to match the previously specified v24, which could cause compatibility issues or unexpected build failures.
Fix: Add Node.js setup before pnpm setup:
- name: Setup Node.js
uses: actions/setup-node@v6
with:
node-version: "24"
- name: Setup pnpm
uses: pnpm/action-setup@v6
with:
version: 10.24.0| - name: Setup pnpm | |
| uses: pnpm/action-setup@v6 | |
| with: | |
| node-version: "24" | |
| version: 10.24.0 | |
| - name: Setup Node.js | |
| uses: actions/setup-node@v6 | |
| with: | |
| node-version: "24" | |
| - name: Setup pnpm | |
| uses: pnpm/action-setup@v6 | |
| with: | |
| version: 10.24.0 | |
Spotted by Graphite
Is this helpful? React 👍 or 👎 to let us know.
2 participants
Add pretest checks for types, style, formatting, and compilation.
Closes #81