feat: rework decision-card to make it based on AST parsing#41
Merged
PatrickSys merged 3 commits intomasterfrom Feb 21, 2026
Merged
feat: rework decision-card to make it based on AST parsing#41PatrickSys merged 3 commits intomasterfrom
PatrickSys merged 3 commits intomasterfrom
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Greptile SummaryThis PR adds comprehensive test coverage for the edit decision card and scope-prefixed snippets features that were implemented in PR #40. It also fixes a null-pointer crash in The changes are documentation and test-focused:
All test plan items are verifiable and accurate. Confidence Score: 5/5
|
| Filename | Overview |
|---|---|
| src/analyzers/generic/index.ts | Fixed null-pointer crash by adding content guard in summarize() and typed extractFirstComment() parameter |
| tests/search-decision-card.test.ts | Added comprehensive tests for edit intent decision card output shape and fields |
| tests/search-snippets.test.ts | Added tests verifying snippets with scope headers when includeSnippets: true |
Last reviewed commit: 397d509
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
intent="edit", results now include a decision card (preflight) telling you whether there's enough evidence to proceed.ready: truemeans proceed.ready: falsecomes withnextAction(what to look up first) andwhatWouldHelp(specific searches to close the gap).includeSnippets: truenow prepends a scope comment (// ClassName.methodName) to each snippet so agents can orient without an extra file read.Test plan
npm testpasses (234 tests, 0 failures)intent="edit"returnspreflight.readyas booleanincludeSnippets: truereturns snippet starting with//## [Unreleased]blockGenerated with Claude Code (claude.com/claude-code)