fix: restore confidence and riskLevel variables broken by refactoring#43
Closed
Copilot wants to merge 3 commits intofeat/cli-all-toolsfrom
Closed
fix: restore confidence and riskLevel variables broken by refactoring#43Copilot wants to merge 3 commits intofeat/cli-all-toolsfrom
Copilot wants to merge 3 commits intofeat/cli-all-toolsfrom
Conversation
…mmits Co-authored-by: PatrickSys <74001504+PatrickSys@users.noreply.github.com>
Reverts problematic refactoring from commits 15fb852 and 1676134: - Uncommented confidence calculation (was breaking editPreflight) - Renamed _riskLevel back to riskLevel (variable was unused) Note: 7 test failures are pre-existing (confirmed at commit de93ae8) Co-authored-by: PatrickSys <74001504+PatrickSys@users.noreply.github.com>
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Add CLI commands for all MCP tools
fix: restore confidence and riskLevel variables broken by refactoring
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What / Why
Commits 15fb852 and 1676134 introduced bugs in
search-codebase.tsthat broke preflight decision card logic:confidencecalculation (line 537) - still used ineditPreflightobject, causing undefined referenceriskLevelto_riskLevel(line 501) - underscore prefix indicated unused, but variable is consumed by decision card outputBoth variables are required for search intent="edit|refactor|migrate" workflows.
Changes:
const confidence = computeIndexConfidence()let riskLevel: 'low' | 'medium' | 'high' = 'low'and its assignmentsNote: 7 test failures are pre-existing (confirmed at commit de93ae8, before CLI implementation). Root cause: indexer returns 0 chunks in test environment due to huggingface.co network issues. Unrelated to this fix.
Release notes
This should appear in release notes as a bug fix for the CLI feature.
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.