chore: remove yabacon/paystack-php, use custom API client #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace the unmaintained yabacon/paystack-php SDK (broken on PHP 8.3+) with a lightweight Gateway/PaystackApiClient using curl directly. - Replace CSP XML whitelist with PHP-based PolicyCollector for backward compatibility across Magento versions. Fix PHP 8.2+ dynamic property deprecation in ConfigProvider and quoteId type mismatch in payment verification. Closes PaystackHQ#60
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #60 Removes the unmaintained
yabacon/paystack-phpSDK (broken on PHP 8.3+) and replaces it with a lightweightGateway/PaystackApiClientusing curl directly.Changes
Gateway/PaystackApiClient.php) — handles transaction initialization, verification, webhook signature validation, and plugin tracker logging via curlcsp_whitelist.xmlwith a PHP-basedCspPolicyCollectorthat works across all Magento 2.4.x versions (the XML version schema changed in 2.4.8)$storeproperty declaration inConfigProviderto resolve dynamic property deprecation===) forquoteIdthat caused order status to stay "pending" after successful paymentorderSender->send()in try-catch so email delivery failures don't break the payment verification flowdev/) — one-command setup with Magento 2.4.8-p3, OpenSearch, 5 test products with images, and pre-configured Paystack test modeTest plan
charge.successand updates orderdev/directory works end-to-end