Update documentation of C:N calls #205
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dd PR preview to publish-docs.yml
…doesn't show up as skipped by splitting docs build and publish workflows; renamed files for clarity and sorting
dlebauer
requested review from
Alomir,
infotroph,
mdietze and
mswilburn
as code owners
Alomir
reviewed
Jan 5, 2026
| $$ | ||
|
|
||
| Where $k_CN$ is a scaling parameter that controls the sensitivity of decomposition rate to C:N ratio. This parameter represents the half-saturation constant of the Michaelis-Menten equation. | ||
| Where $k_{CN}$ is a scaling parameter that controls the sensitivity of decomposition rate to C:N ratio. This parameter represents the half-saturation constant of the Michaelis-Menten equation. |
Collaborator
There was a problem hiding this comment.
Hmmm, this is not really a Michaelis-Menten form, so that much of this comment should probably change.
Do we want to formulate D_{CN} as (k/(k+CN), and label k as "the CN ratio at which the dependency is 1/2"? (This is identical to the current form if k_new is equal to 1/k_current)
We could also formulate this in an analogous way with the D_N_min equation, and use the form 1/(1+CN/k), which is equivalent to k/(k+CN).
Member
Author
There was a problem hiding this comment.
Thanks for pointing this out. I've addressed it in #216. Hopefully I haven't caused too many conflicts!
Member
Author
|
Closing; have included these changes and more in #216 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Alomir please update the description if needed.
In particular this sentence should reflect that CN is calculated on demand when used (if that is correct, as discussed in recent conversation about creating a cn calculating function instead of adding a state variable).
note: there are many commits assoc. w/ this PR b/c I did
git merge --no-ffinstead of rebase. I was just trying minimize merge drama; this is apparently expected behavior.