SIP287 Add C Saturation#301
Draft
mswilburn wants to merge 6 commits into
Draft
Conversation
Alomir
reviewed
Mar 27, 2026
Collaborator
Alomir
left a comment
There was a problem hiding this comment.
New flag option looks good! (Other than the one issue in restart.c)
Comment on lines
164
to
165
| state->flagsPF[8] = (StateField){"flags.carbonSaturation", FT_INT, &modelFlags.carbonSaturation, 0}; | ||
| state->flagsPF[10] = (StateField){"flags.invalid", FT_INVALID, NULL, FIELD_INVALID}; |
Collaborator
There was a problem hiding this comment.
I think these should be flagsPF[10] for carbonSat and flagsPF[11] for invalid
Contributor
Author
There was a problem hiding this comment.
Ah, thanks for catching that. Fixed!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implementing soil carbon saturation by creating a flag, adding a new parameter, modifying fluxes into soil organic carbon pool, adding new flux from soil organic carbon pool to litter pool, and updating documentation. Motivation for this change includes evaluating model soil carbon dynamics with and without an explicit maximum limit for long-term storage.
How was this change tested?
List steps taken to test this change, with appropriate outputs if applicable
If changes are needed for any
sipnet.outfiles in thetest/smokesubdirectories, then include output fromtools/smoke_check.pyby running the commands below and pasting the output at the end of this PR. Note thatthis must be run BEFORE submitting changes to any
sipnet.outfiles.Run
python tools/smoke_check.py helpfor more info.Related issues
Checklist
docs/CHANGELOG.mdupdated with noteworthy changesclang-format(rungit clang-formatif needed)Note: See CONTRIBUTING.md for additional guidance. This repository uses automated formatting checks; if the pre-commit hook blocks your commit, run
git clang-formatto format staged changes.