Feature/create account#43
Merged
ABDULLAHHG merged 50 commits intodevfrom Feb 21, 2026
Merged
Conversation
…test/create-account
marah222
approved these changes
Jan 21, 2026
Comment on lines
+32
to
+35
| create: (context) => CreateAccountCubit( | ||
| context.read<AuthenticationValidator>(), | ||
| context.read<AuthenticationRepository>(), | ||
| ), |
Collaborator
There was a problem hiding this comment.
i think you can use getIt? since you registerd it ?
| await client.auth.signUp( | ||
| email: user.email, | ||
| password: password, | ||
| data: { "name" : user.username} |
Collaborator
There was a problem hiding this comment.
we need all data user intered in flow to be sent in userdata like
currency , day of salary , etc ..
…reate-account # Conflicts: # lib/core/l10n/app_ar.arb # lib/core/l10n/app_en.arb # lib/design_system/assets/app_assets.dart
…reate-account # Conflicts: # lib/design_system/assets/app_assets.dart
# Conflicts: # lib/data/repository/authentication_repository.dart # lib/design_system/assets/app_assets.dart # lib/di/injection.dart # lib/domain/entity/user.dart # lib/domain/validator/authentication_validator.dart
# Conflicts: # lib/core/l10n/app_en.arb
…reate-account # Conflicts: # lib/design_system/assets/app_assets.dart # lib/di/injection.dart # pubspec.lock # pubspec.yaml
# Conflicts: # lib/di/injection.dart # lib/presentation/login/screen/login_screen.dart
Closed
…reate-account # Conflicts: # lib/di/injection.dart
# Conflicts: # lib/presentation/navigation/routes.dart # lib/presentation/navigation/routes.g.dart
# Conflicts: # lib/core/di/injection.dart # lib/core/l10n/app_ar.arb # lib/core/l10n/app_en.arb # lib/presentation/login/widget/login_form.dart # lib/presentation/navigation/routes.dart # lib/presentation/navigation/routes.g.dart
| emit(state.copyWith(isLoading: false)); | ||
| }, | ||
| onError: (error){ | ||
| emit(state.copyWith(isLoading: false)); |
Collaborator
There was a problem hiding this comment.
why not in 1 emission ?
| trailing: AppLogo(assetPath: AppAssets.appBrand), | ||
| leading: AppBarCircleButton( | ||
| assetPath: AppAssets.icArrowLeft, | ||
| onTap: () => Navigator.pop(context), |
Collaborator
There was a problem hiding this comment.
is this the right usage of the go route library we have ? please double check
mohamedshemees
approved these changes
Feb 18, 2026
# Conflicts: # lib/core/l10n/app_ar.arb # lib/core/l10n/app_en.arb # lib/data/repository/authentication_repository.dart # lib/domain/repository/authentication_repository.dart # lib/presentation/navigation/routes.dart # lib/presentation/navigation/routes.g.dart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create account screen