Fix/fix e control method enum values#1422
Merged
Merged
Conversation
…pClient entry as last value
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a backward-compatibility regression by stabilizing the backing integer values of eControlMethod (used across comm configuration/serialization and consumer switch statements), preventing ordinal shifts when new enum members are added.
Changes:
- Assign explicit integer values to all
eControlMethodmembers to make values stable across releases. - Reorder
UdpClientto the end of the enum and assign it the next available value (18) so earlier members retain historical values.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
andrew-welker
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1421
This pull request updates the
eControlMethodenum ineControlMethods.csto explicitly assign integer values to each member and reorders theUdpCliententry. This change ensures that the enum values are stable and predictable, which is important for serialization, interoperability, and backward compatibility.Enum improvements and maintenance:
eControlMethodenum to ensure stable and predictable values.UdpCliententry to the end of the enum and assigned it the next available integer value (18), ensuring the order and values are clear and consistent.