Skip to content

Anchor merge direction in describe system prompt#17

Open
plebioda wants to merge 1 commit into
masterfrom
PSMDB-2094-fix-describe-prompt
Open

Anchor merge direction in describe system prompt#17
plebioda wants to merge 1 commit into
masterfrom
PSMDB-2094-fix-describe-prompt

Conversation

@plebioda
Copy link
Copy Markdown
Collaborator

The describe prompt let the model infer direction from filenames and commit summaries, which produced inverted per-file descriptions.

Name target_branch_sha as base and merge_commit as incoming explicitly, require descriptions to follow base->incoming, and instruct the agent to leave a file's description empty when uncertain rather than guess.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the describe system prompt to explicitly anchor merge direction so per-file descriptions consistently describe changes from the fork’s base commit to the incoming upstream commit (and avoid inverted descriptions).

Changes:

  • Defines Base (before) as merge_info.target_branch_sha on merge_info.target_branch.
  • Defines Incoming (after) as merge_info.merge_commit (also merge_context.merge_commit) and mandates describing auto-merged files as base → incoming.
  • Instructs the agent to leave a file’s description empty when direction is uncertain rather than guessing.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/mergai/prompts/system_prompt_describe.md Outdated
@plebioda
Copy link
Copy Markdown
Collaborator Author

The describe prompt let the model infer direction from filenames and
commit summaries, which produced inverted per-file descriptions.

Name target_branch_sha as base and merge_commit as incoming explicitly,
require descriptions to follow base->incoming, and instruct the agent
to leave a file's description empty when uncertain rather than guess.
@plebioda plebioda force-pushed the PSMDB-2094-fix-describe-prompt branch from 4232dfa to 3cece89 Compare May 25, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants