PS-11080 fix: Spoiled logical clock information in rewritten binlog (part 4)#129
Merged
percona-ysorokin merged 1 commit intoMay 26, 2026
Conversation
…part 4) https://perconadev.atlassian.net/browse/PS-11080 Added MTR test cases for the 'sequence_number' / 'last_committed' field rewrite logic: * 'gtid_renumbering' - checks for renumbering when remote rotation occurs. * 'gtid_renumbering_local_rotation' - checks for renumbering when local rotation occurs. * 'gtid_renumbering_resume' - checks that 'last_sequence_number' is restored properly from the binlog metadata file upon PBS restart. * 'gtid_renumbering_resume_after_partial' - checks that 'last_sequence_number' in the binlog metadata file always corresponds to the actual data file (not the last seen value currently in the storage buffer). This helps with resuming PBS after the crash. Currently 'gtid_renumbering_resume_after_partial' MTR test case requires DEBUG_SYNC functionality to be available in the MySQL Server. Unfortunately, at the moment we use release tarballs of the MySQL Server in GitHub Actions workers and this test will always be skipped there. Co-authored-by: Yura Sorokin <yura.sorokin@percona.com>
percona-ysorokin
force-pushed
the
sequence_number_rewrite_mtr
branch
from
64a7287 to
68dfc85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/PS-11080
Added MTR test cases for the 'sequence_number' / 'last_committed' field
rewrite logic:
occurs.
properly from the binlog metadata file upon PBS restart.
in the binlog metadata file always corresponds to the actual data file (not the
last seen value currently in the storage buffer). This helps with resuming PBS
after the crash.
Currently 'gtid_renumbering_resume_after_partial' MTR test case requires
DEBUG_SYNC functionality to be available in the MySQL Server. Unfortunately,
at the moment we use release tarballs of the MySQL Server in GitHub Actions
workers and this test will always be skipped there.