Set up build automation and add some unit tests#4
Open
hprange wants to merge 6 commits intoPeterBrockfeld:masterfrom
Open
Set up build automation and add some unit tests#4hprange wants to merge 6 commits intoPeterBrockfeld:masterfrom
hprange wants to merge 6 commits intoPeterBrockfeld:masterfrom
Conversation
The build is configured to verify the code using JSHint, uglify the code and run tests in the spec folder.
|
Hey @hprange, nice work ! As @PeterBrockfeld seem to be off from Github (have a look at his activity map), what about releasing your fork on npmjs and open a PR here to deprecate this repo? |
Author
|
@zedtux Sounds good to me. I'll work on that. |
Author
|
@zedtux I've deployed a package to NPM including the changes of all pull requests. |
|
That's awesome ! Thank you @hprange ! 👍 Can you please enable the issues on your repo? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request doesn't change any logic. It adds the required configuration to verify, test and minify the BarcodeParser source code using Grunt + NPM. The idea is to pave the way for future improvements.