Use sys.exit() instead of exit()#1
Open
TheGittyPerson wants to merge 4 commits intoPetter12131451:mainfrom
Open
Use sys.exit() instead of exit()#1TheGittyPerson wants to merge 4 commits intoPetter12131451:mainfrom
sys.exit() instead of exit()#1TheGittyPerson wants to merge 4 commits intoPetter12131451:mainfrom
Conversation
Petter12131451
force-pushed
the
main
branch
28 times, most recently
from
cd0d324 to
b678ed1
Compare
Petter12131451
force-pushed
the
main
branch
19 times, most recently
from
852709e to
32db7cb
Compare
Petter12131451
force-pushed
the
main
branch
8 times, most recently
from
efe13ae to
71bdd55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! I found a slight issue in your program, but could not find the "Issues" tab you were referring to in your README.md (perhaps you forgot to set up one), so I just did a normal fork and pull request here.
Issue I fixed
Originally, your program used
exit()to exit the program, but this function is specifically designed for the interactive Python shell (REPL), which I don't think is what you intend for users to run your program in. When I run the program in IDLE, for example, the shell window opens a pop-up that says "Your program is still running! Do you want to kill it?", and closes the shell window completely after pressing "OK". I assume this isn't the expected behaviour.I have changed the
exit()calls in your code tosys.exit(), which is a more suitable way to exit the program.Please review the changes I made, and please do ask questions or request clarification!