Merged
Conversation
Contributor
|
In the case where the PR includes GUI features or modifications, could you add a screenshot? |
Author
DebuggingSpy-Browser-Tests/DSRecordBrowserPresenterTest.class.st
Outdated
Show resolved
Hide resolved
DebuggingSpy-Browser-Tests/DSRecordBrowserPresenterTest.class.st
Outdated
Show resolved
Hide resolved
f2a044c to
34fa194
Compare
Author
0a46141 to
c98a4d7
Compare
Author
Julesboul
requested changes
Apr 10, 2026
Contributor
Julesboul
left a comment
There was a problem hiding this comment.
As you changed the windowType and introduced a system of dispach, you should changed the way of getting the windowType in DSWindowEvents also (and things linked to this change)
In short, it is good and makes DSSpy more modular.
However, don't forget that tests does not need to be modular (on the oppositite, it is good that people must changed their tests after modifying things - as the behavior changed). It not always funny and sometimes takes time, but we are used to writing hardcoded values and handmade objects in tests.
DebuggingSpy-Browser-Tests/DSRecordBrowserPresenterTest.class.st
Outdated
Show resolved
Hide resolved
Julesboul
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


No description provided.