Skip to content

Feat/color referential#43

Merged
Julesboul merged 40 commits intoPharo-XP-Tools:P14from
nicolasp025:feat/color-referential
Apr 13, 2026
Merged

Feat/color referential#43
Julesboul merged 40 commits intoPharo-XP-Tools:P14from
nicolasp025:feat/color-referential

Conversation

@nicolasp025
Copy link
Copy Markdown

No description provided.

@nicolasp025 nicolasp025 marked this pull request as ready for review April 9, 2026 08:21
@nicolasp025 nicolasp025 requested a review from Julesboul April 9, 2026 08:21
@StevenCostiou
Copy link
Copy Markdown
Contributor

In the case where the PR includes GUI features or modifications, could you add a screenshot?
It helps viewing what the code does.

@nicolasp025
Copy link
Copy Markdown
Author

It does something like this. I didn't figured how to make a button that would expand / fold the referential for now but I did it resizeable so you could just resize the color referential to hide it if needed.

Capture d’écran 2026-04-09 à 10 24 19

@nicolasp025 nicolasp025 force-pushed the feat/color-referential branch from f2a044c to 34fa194 Compare April 9, 2026 09:00
@nicolasp025
Copy link
Copy Markdown
Author

The window color indicator does something like this :
Capture d’écran 2026-04-10 à 10 40 57

Which permits to display the window type in which the events happened.

@nicolasp025 nicolasp025 force-pushed the feat/color-referential branch from 0a46141 to c98a4d7 Compare April 10, 2026 13:01
@nicolasp025
Copy link
Copy Markdown
Author

nicolasp025 commented Apr 10, 2026

The new colors look like this :
Capture d’écran 2026-04-10 à 15 14 39

Copy link
Copy Markdown
Contributor

@Julesboul Julesboul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you changed the windowType and introduced a system of dispach, you should changed the way of getting the windowType in DSWindowEvents also (and things linked to this change)

In short, it is good and makes DSSpy more modular.
However, don't forget that tests does not need to be modular (on the oppositite, it is good that people must changed their tests after modifying things - as the behavior changed). It not always funny and sometimes takes time, but we are used to writing hardcoded values and handmade objects in tests.

@nicolasp025 nicolasp025 requested a review from Julesboul April 13, 2026 12:10
@Julesboul Julesboul merged commit c758df4 into Pharo-XP-Tools:P14 Apr 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants