-
Notifications
You must be signed in to change notification settings - Fork 45
Add Assassin's Creed: Odyssey #976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a1cdba1 to
ed6b07e
Compare
|
Does the game run? |
|
|
Blocking pr has been merged. Is this working now? |
Based on available info it should, but i didn't have the opportunity to test it on phoenicis yes so either push in testing or wait for me to test. |
|
In this case, please state this in the pull request description set the pull request to draft. Same for other pull requests like explained before. |
*push request, stop allowing github to confuse ppl :p Insane, but okay |
|
Like explained before, we cannot accept untested pull requests. Therefore I will close this until it is tested. |
|
Why do we have testing flag then.. w/e i will adapt for testing then.. |
|
To quote from the documentation:
|
|
@plata seems fitting for all my AC scripts |
|
No. You cannot even be sure that it works at all. |
|
@plata because phoenicis is unable to install any steam game, adapt patches for games that depends on them like league of legends and your wine has different results compared to system wine. if you provided system wine and resolved the quickscripts i can quarantee you that specified version of game will work. |
Credit: https://github.com/Haoose/UPLAY_GAME_ID/blob/master/README.md
Blocked by: #978
Blocked by: #881 -> Can't test!