Redirect tl_expected to system libexpected-dev when available#12
Redirect tl_expected to system libexpected-dev when available#12otamachan wants to merge 5 commits intoPickNikRobotics:mainfrom
Conversation
Signed-off-by: Tamaki Nishino <otamachan@gmail.com>
|
At first place I was wondering why I couldn't see your deprecation warning building RSL against your branch: It picked the tl_expected header from rcpputils. I did not know before that this was packaged there. Should we maybe simply remove it here and let ROS PMC handle this in rcpputils? Changing the includes from |
|
Thanks for the insight. On the other hand, Regarding the deprecation warning not appearing — I'll investigate later. |
This comment was marked as outdated.
This comment was marked as outdated.
|
Sorry, I tried now to just include rcpputils, and it did not work without adapting the includes to <rcpputils/..> as you pointed out: PickNikRobotics/RSL#157 |
Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Signed-off-by: Tamaki Nishino <otamachan@gmail.com>
christophfroehlich
left a comment
There was a problem hiding this comment.
Shouldn't we remove USE_VENDORED_TL_EXPECTED and just delete the code?
At least this was my proposal in PickNikRobotics/generate_parameter_library#311 (comment) (open for discussion).
Apart from that, the deprecation warning and redirection works as expected. Tested with PickNikRobotics/generate_parameter_library#322 and joint_trajectory_controller
This PR updates
tl_expected/expected.hppto redirect to the systemtl/expected.hppwhen availablelibexpected-devis installed (detected via__has_include),tl_expected/expected.hppredirects to the systemtl/expected.hppwith a deprecation warninglibexpected-devis not available (e.g., Windows), the vendored implementation is used as before-DUSE_VENDORED_TL_EXPECTED=ONlibexpected-devasbuild_export_dependto ensure rosdep installs the system packageRelated to