Fix: Increase ICP max_correspondence_distance to fix flaky CI#530
Open
davetcoleman wants to merge 1 commit intomainfrom
Open
Fix: Increase ICP max_correspondence_distance to fix flaky CI#530davetcoleman wants to merge 1 commit intomainfrom
davetcoleman wants to merge 1 commit intomainfrom
Conversation
The Register CAD Part Subtree used max_correspondence_distance=0.5m, which intermittently fails in CI when simulated point clouds don't have enough correspondences within that radius. Increase to 1.0m (default is 5.0m) to make registration more robust while still being a meaningful constraint. Fixes PickNikRobotics/moveit_pro#17394 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max_correspondence_distancefrom 0.5m to 1.0m inRegister CAD Part SubtreeRegisterPointCloudsfailures in CI with "Not enough point correspondences"Fixes PickNikRobotics/moveit_pro#17394
Test plan
Stack Objects with ICPpasses consistentlyRegister CAD Partlocally in lab_sim to verify ICP registration still produces accurate results🤖 Generated with Claude Code