Support inverted display of suggestions#68
Open
danwild wants to merge 2 commits intoPixabay:masterfrom
Open
Conversation
|
I'm not sure if I'm using this wrong, but I can't get it to work. Second, it still displays the dropdown below the input. My element is far enough from the bottom that I can still see the dropdown, but as it is about 75% down I would prefer to get the behavior shown above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nice plugin thanks 👍
This PR adds optional params:
body)The addition of these options allows us to use this plugin for inverted display of suggestions.
Why? If you try and use this in a footer it doesn't work so well - because there is no room to display the suggestions below.
Here's how it works now, with inverted options (and some css tweaks):